Bug Fixes & Enhancements in Payroll Application

[unreal0901]

Fixed Issues:

1. 302 Redirect Issue on Sending Payslip:
   • When clicking "Send Mail" multiple times, the request GET /payroll/send-slip?id=1 resulted in a 302 redirect to filter-slip, .
   • This led to automatic hiding of table columns due to the filter request sometimes.
   • Fix: Appended view=table to the request to ensure the correct view state is maintained and columns remain visible.
   • Implementation:

     hx-get="{% url 'send-slip' %}?id={{payslip.id}}&view=table"

   • Note: Unsure if this is the best approach, but it prevents automatic column hiding.

After clicking send button 2-3 times, empty filter request is being set which is hiding the columns.

Also why this red dot is coming on top?

2. Grammar Correction in Confirmation Message:
   • Fixed "sent" → "send" for better clarity in:

     hx-confirm="{% trans 'Do you want to send the payslip by mail?' %}"

3. Fallback to Personal Email if Work Email is Absent:
   • Ensures that the employee's personal email is used if their work email is missing.
   • Updated method:

     def get_mail(self):
         """
         Returns the employee's email, preferring the work info email if available.
         """
         work_info = getattr(self, "employee_work_info", None)
         work_email = getattr(work_info, "email", None)
         
         return work_email if work_email is not None else self.email

• wkhtmltopdf Requirement for PDF Generation:
  • Need to confirm whether wkhtmltopdf executable should be installed for generating PDF payslips.

---

Testing & Validation Steps:

1. Click "Send Mail" multiple times and verify that table columns remain visible.
2. Check that the fallback email logic works as expected.
3. Validate the grammar correction in the confirmation message.
4. Confirm if PDF generation works correctly after installing wkhtmltopdf.

[horilla-opensource]

Hi @unreal0901 ,

Thank you for reporting this issue and for providing detailed insights!.

We'll test these fixes thoroughly and update accordingly.

Thanks again for your valuable contribution! 🚀

Best Regards,
Team Horilla