Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Feedback System with Answer Justifications #531

Open
Rmcd20 opened this issue Feb 25, 2025 · 6 comments
Open

Enhance Feedback System with Answer Justifications #531

Rmcd20 opened this issue Feb 25, 2025 · 6 comments

Comments

@Rmcd20
Copy link
Contributor

Rmcd20 commented Feb 25, 2025

Description:
Currently, the feedback system allows users to select answers but lacks a structured way to include justifications or observations for their choices. This feature request proposes the addition of answer justifications in the feedback module to enhance the clarity and depth of responses.

Proposed Solution:
Backend:

Add a justification field to the Answer model.
Ensure justifications are stored correctly when saving feedback responses.
Modify API endpoints (get_feedback_answers, get_feedback_overview) to include justifications.
Frontend:

Update UI to display justifications below selected answers.
Ensure justifications appear in the feedback review/overview sections.
Modify the sidebar ("Answers") to load justifications dynamically via AJAX.

Benefits:

  • Provides more context for selected answers.
  • Improves feedback clarity for managers and reviewers.
@Rmcd20
Copy link
Contributor Author

Rmcd20 commented Feb 25, 2025

Summary of Changes and Improvements Implemented PR/#532 addresses Issue #531

This PR implements the requested enhancements outlined in Issue #531, specifically adding support for answer justifications in the feedback system. The changes ensure that justifications are stored, displayed correctly in the UI, and retrievable via the API, improving feedback clarity and usability.

However, some adjustments might still be needed in the Feedback Overview, as observations are not yet appearing as expected. I'll take care of that and make the necessary updates soon.

Let me know if you have any feedback! 🚀

@horilla-opensource
Copy link
Owner

Hi @Rmcd20 ,

Thanks for the update and for implementing the requested enhancements in PR/#532! The addition of answer justifications is a great step toward improving feedback clarity and usability.

Noted on the Feedback Overview adjustments—once observations are fully integrated and displayed as expected, it’ll make the system even more effective. We will check to merge this with our existing code and run tests to ensure everything works smoothly.

Appreciate your effort on this! Looking forward to the final refinements.

Best Regards
Team Horilla

@Rmcd20
Copy link
Contributor Author

Rmcd20 commented Feb 26, 2025

Hi Team Horilla,

Following up on PR/#532, I’ve completed the necessary adjustments to fully integrate observations (justifications) into the Feedback Overview. Here’s what I improved:

Fixes & Enhancements:
✅ UI Adjustments:

Ensured justifications appear correctly in the Feedback Overview, aligned with each employee’s response.
Updated the table structure to properly display justifications in the “Observations” column alongside the selected answers.
✅ Backend Updates:

Adjusted API endpoints (get_feedback_answers, get_feedback_overview) to correctly retrieve and include justifications.
Ensured justifications are stored and displayed dynamically when feedback responses are reviewed.
✅ Translations & Localization:

Added translations for Feedback Overview labels and messages related to observations in multiple languages (Arabic, German, English, Spanish, French, and Brazilian Portuguese).

@christabeladdo
Copy link

Hi @Rmcd20, how can we take advantage of these changes?

@Rmcd20
Copy link
Contributor Author

Rmcd20 commented Feb 27, 2025

Hi @christabeladdo,

Thanks for your question! These changes enhance the Feedback System by integrating answer justifications into the review process. Here's how you can take advantage of them:

🔹 Key Benefits & Usage:

✅ For End Users:

When submitting feedback, users can now add justifications alongside their selected answers.
Justifications provide context and explanations for their choices, making responses more insightful.

✅ For Managers & Reviewers:

Justifications are now visible in the Feedback Overview, properly aligned with each answer under the new "Observations" column.
This ensures that managers can quickly understand the reasoning behind responses without needing follow-ups.
✅ For API Integrations:

The updated API endpoints (get_feedback_answers, get_feedback_overview) now include justifications, making it easier to retrieve and analyze user feedback.

📌 Next Steps
If you're using the latest version, justifications should automatically appear in the review sections. Let me know if you need further guidance on implementation or testing!

Looking forward to your feedback. 🚀

Best,
@Rmcd20

@christabeladdo
Copy link

christabeladdo commented Feb 27, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants