Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve UX on live feature monitoring page #6219

Closed
manjitapandey opened this issue Jan 25, 2024 · 4 comments
Closed

Improve UX on live feature monitoring page #6219

manjitapandey opened this issue Jan 25, 2024 · 4 comments
Assignees
Labels
data-quality Issues related to data quality and validation workflow

Comments

@manjitapandey
Copy link

manjitapandey commented Jan 25, 2024

Describe the solution you'd like
We can improve UX by making the live feature monitoring page more similar to the edit screen, where there’s no footer, the map is fixed to the available screen space and the right sidebar is the only space where scroll is enabled.

Additional context
Something similar to id editor page.
image

@manjitapandey manjitapandey added the data-quality Issues related to data quality and validation workflow label Jan 25, 2024
@royallsilwallz royallsilwallz self-assigned this Jan 25, 2024
royallsilwallz added a commit that referenced this issue Jan 25, 2024
@emi420
Copy link
Collaborator

emi420 commented Jan 25, 2024

Hey @royallsilwallz , it's improving! just a couple of fixes:

Tag filter and dropdown for selecting background has to be moved close to the top

It's using an absolute position, maybe something like top: 100px for the .top class will solve the issue. I'm open to other solutions also. Also, as you'll be working with the styling of this form, please check the alignment between the dropdown and the other elements and the value for the rounded corner of the "Search" button (to keep design consistent).

Screenshot 2024-01-25 at 08 52 22

There's a scroll so the user can move the screen

An overflow: hidden could be used for disabling scroll on the container.

Screenshot 2024-01-25 at 08 55 43

Also you have to take into a account the height of of the project's title and then the feature list at the bottom. Currently, the list's seems to be exceeding the available space. This is visible if you add a border: 1px solid red for testing:

Screenshot 2024-01-25 at 09 03 57

@royallsilwallz
Copy link
Contributor

Yeah sure @emi420. I'll be working on these changes.

royallsilwallz added a commit that referenced this issue Jan 29, 2024
@royallsilwallz
Copy link
Contributor

Hey @emi420, I've fixed the design changes and pushed the code. Can you review it and let me know ?

@emi420
Copy link
Collaborator

emi420 commented Feb 12, 2024

Hey @royallsilwallz , everything looks nice!

@emi420 emi420 closed this as completed Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data-quality Issues related to data quality and validation workflow
Projects
None yet
Development

No branches or pull requests

3 participants