Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Export directory prefix #16

Merged
merged 11 commits into from
Aug 6, 2024
Merged

Conversation

jay-tau
Copy link
Collaborator

@jay-tau jay-tau commented Jun 7, 2024

Solves #10

@jay-tau jay-tau force-pushed the feat-export-dir branch from a7090eb to a4f7468 Compare June 7, 2024 14:03
@jay-tau jay-tau force-pushed the feat-export-dir branch from 76cf591 to a0d5e12 Compare June 7, 2024 14:10
@jeanbez jeanbez self-assigned this Jun 12, 2024
@jay-tau jay-tau requested a review from jeanbez June 18, 2024 14:02
@jay-tau jay-tau marked this pull request as ready for review June 18, 2024 14:02
@jeanbez
Copy link
Member

jeanbez commented Jun 25, 2024

@jay-tau could you please confirm that this change will not impact when this module is called from the dxt-exporer module? Do we need to change any parameters there?

@jeanbez jeanbez added this to the v0.8 milestone Jun 25, 2024
@jeanbez jeanbez added bug Something isn't working enhancement New feature or request labels Jun 25, 2024
@jay-tau
Copy link
Collaborator Author

jay-tau commented Jul 18, 2024

hpc-io/dxt-explorer#23 should ensure that dxt-explorer continues to function as expected.
However, I think it would be wise to hold of on updating the dxt-explorer, till we test it with Drishti v0.8
I have currently tested it with the Drishti present in this branch.

@jeanbez jeanbez merged commit 938a21a into hpc-io:master Aug 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants