Add a possibility to explicitly override the soname during initialization #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This generally looks good, but the other features of the generator are document with the examples, this one is not. Could you add a trivial example showing how this is supposed to be used? If that is in place I'd be happy to merge this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For purposes of mock testing, it would be very useful if I could explicitly override the .so name when initializing the dynamic loader.
This PR keeps all the existing behavior and initialize_{library} still works as before. But it also introduces a initialize_{library}_explicit where the caller can explicitly pass the .so name.
Please consider merging this as I think it adds some useful functionality while having low impact/risk.