Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEST_MAXFILESIZE should or could be usable together with USESAFEDOCKER #14

Closed
ifrh opened this issue Dec 22, 2022 · 1 comment
Closed
Assignees

Comments

@ifrh
Copy link
Contributor

ifrh commented Dec 22, 2022

In README.md it is mentioned:

The maximum size of a file produced by a user submission (setting TEST_MAXFILESIZE, currently not supported with USESAFEDOCKER, until http://stackoverflow.com/questions/25789425 is resolved)

In http://stackoverflow.com/questions/25789425, which has been posted in Nov 2014, there exists an answer from the year 2015 points to a Docker Issue which has been closed as implemented for using ulimits. ( cf. KITPraktomatTeam/Praktomat#358 )

@hannesbraun
Copy link
Contributor

hannesbraun commented Dec 22, 2022

This should be already implemented:

if fileseeklimit:
command += ["--ulimit", "fsize=%d" % fileseeklimitbytes]

Granted, I forgot to update the README... which is fixed now as well: 19c2c6f

@hannesbraun hannesbraun self-assigned this Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants