Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make this repo pip installable #24

Open
breznak opened this issue May 2, 2016 · 18 comments
Open

make this repo pip installable #24

breznak opened this issue May 2, 2016 · 18 comments

Comments

@breznak
Copy link
Member

breznak commented May 2, 2016

so it can be conveniently used along nupic.

It should be possible to install with:
python setup.py install
which will install content of nupic/audio/ and make it accessible from anywhere with:
python -c 'from nupic.audio.encoders.wave import WAVEncoder'

@breznak breznak mentioned this issue May 6, 2016
@breznak
Copy link
Member Author

breznak commented May 6, 2016

@rhyolight do you remember who made the pip version e.g. of nupicvision? Would be really nice if they could help us quickly implement the same for this repo. Not the experiments themselves, but the "common" part nupicaudio/ as presented in #26 (dependencies: scipy)

@breznak breznak mentioned this issue May 6, 2016
6 tasks
@rhyolight
Copy link
Contributor

@breznak I don't know but maybe Scott, but don't bother him please, he's pretty busy. This should be a trivial task for any experienced python programmer. If you can't find anyone, maybe I could do it next week.

@rcrowder
Copy link
Member

rcrowder commented May 8, 2016

@breznak I'm not sure what the point would be to lock this repo into a pip install-able state, as opposed to git cloning it. In the future I can imagine changes, such as custom encoders, could be moved from here into the main nupic/nupic.core repository. But until then fail to see why this repo requires packaging?

@breznak
Copy link
Member Author

breznak commented May 9, 2016

@rcrowder uhm..I haven't been very descriptive in the issue, I definitely don't mean to include the experiments. Just the nupicaudio/ subfolder with encoders or any generic-useful stuff.

@breznak
Copy link
Member Author

breznak commented May 12, 2016

@rcrowder @passiweinberger nupic/ content is now a submodule of nupic and is installable with setup.py , ...OK, this is what I meant with "pip installable".

Hope you guys are OK with that?

Also, if you want, it would be nice if you could add requirements of your experiments to requirements.txt (commented out, as the experiments are optional)

@passiweinberger
Copy link
Member

Check! 🚀🤓
I think having the requirements in each experiment separately is easier and leaner :)

I'll sit on it tmw!

--Pascal

Best,

Pascal Weinberger


Co-Founder & CTO
GAIA Solutions Ltd.
meetGaia.com

BE THE CHANGE YOU WANT TO SEE IN THE WORLD ...

PLEASE NOTE: This email and any file transmitted are strictly confidential and/or legally privileged and intended only for the person(s) directly addressed. If you are not the intended recipient, any use, copying, transmission, distribution, or other forms of dissemination is strictly prohibited. If you have received this email in error, please notify the sender immediately and permanently delete the email and files, if any.
Please consider the environment before printing this message.

On 12 May 2016, at 11:43, breznak [email protected] wrote:

@rcrowder @passiweinberger nupic/ content is now a submodule of nupic and is installable with setup.py , ...OK, this is what I meant with "pip installable".

Hope you guys are OK with that?

Also, if you want, it would be nice if you could add requirements of your experiments to requirements.txt (commented out, as the experiments are optional)


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub

@breznak
Copy link
Member Author

breznak commented May 12, 2016

having the requirements in each experiment separately is easier and leaner

True, that would be best imho 👍

Also, when you are at checking your experiment, please take a look at #26 if you could find a use for it

@passiweinberger
Copy link
Member

#28

@breznak
Copy link
Member Author

breznak commented May 12, 2016

Reopening as #26 is not working with this!
Please help me with:

python setup.py install
python -c "import nupic.audio"

@breznak breznak reopened this May 12, 2016
@breznak
Copy link
Member Author

breznak commented May 12, 2016

@rhyolight I'm stuck here with setup.py, copied the examples from nupic/nupic.vision + searched help. Btw, it seems setup.py in nupic.vision is not working either(?) Can you suggest someone to help?
@david-ragazzi do you know setup.py files?

@rhyolight
Copy link
Contributor

@breznak I'll take a look at the setup.py stuff in a bit...

@breznak
Copy link
Member Author

breznak commented May 12, 2016 via email

@rhyolight
Copy link
Contributor

@breznak So it didn't work?

@breznak
Copy link
Member Author

breznak commented May 13, 2016

Nope 😞 I've added validation instructions in the Issue description:

python setup.py install
which will install content of nupic/audio/ and make it accessible from anywhere with:
python -c 'from nupic.audio.encoders.wave import WAVEncoder'

What I can do is cd nupic/ and python -c 'from audio.encoders.wave import WAVEncoder;
but I could that even before and it is not what we want (i think?) We want absolute imports to work!

PS: I'm not sure if the namespace package is suitable for this repo? (but didn't work even w/o it imho).

CC @rhyolight

@rhyolight
Copy link
Contributor

I thought he problem was with scipy. When I ran pip install -r requirements.txt, it worked fine, but declaring scipy or numpy in the
install_requires block kept throwing that TypeError, and I don't know why.


Matt Taylor
OS Community Flag-Bearer
Numenta

On Fri, May 13, 2016 at 9:28 AM, breznak [email protected] wrote:

Nope [image: 😞] I've added validation instructions in the
Issue description:

python setup.py install
which will install content of nupic/audio/ and make it accessible from
anywhere with:
python -c 'from nupic.audio.encoders.wave import WAVEncoder'

What I can do is cd nupic/ and python -c 'from audio.encoders.wave import
WAVEncoder;
but I could that even before and it is not what we want (i think?) We want absolute
imports to work!

PS: I'm not sure if the namespace package is suitable for this repo? (but
didn't work even w/o it imho).

CC @rhyolight https://github.com/rhyolight


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#24 (comment)

@rcrowder
Copy link
Member

@breznak I tried last weekend to get this as a submodule of nupic. But couldn't get it work. I'll have another look this weekend.

@breznak
Copy link
Member Author

breznak commented May 22, 2016

@rcrowder did you have any luck? I'll give it a try too.

@rcrowder
Copy link
Member

@breznak I'm having another look now. It takes a while to reconfigure my system to cope with nupci forcing older package install (e.g. numpy==1.9.2), but you're last merge here looks like it has gone a long way towards getting it to work.

@rcrowder rcrowder mentioned this issue May 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants