Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong output #45

Open
MyselfYangjz opened this issue Apr 7, 2024 · 3 comments
Open

Wrong output #45

MyselfYangjz opened this issue Apr 7, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@MyselfYangjz
Copy link

MyselfYangjz commented Apr 7, 2024

Hello, I read your source code, and conducted a test, found that when the variable is first user input, and then defined as a string, there will still be an error detection of the vulnerability, as follows:
sub main {
my $name = $ARGV[0];
my $name = "aasa";
system ("echo Hello World! $name");
}

I checked your source code and found that it is caused by find_first only looking at the first defined variable. (AST.PL)

image

@htrgouvea htrgouvea added the bug Something isn't working label Apr 7, 2024
@MyselfYangjz
Copy link
Author

I have made an update that can effectively deal with this situation, you can check if this way is reasonable。
AST_update.zip

@htrgouvea
Copy link
Owner

htrgouvea commented Apr 9, 2024

Hi @MyselfYangjz, you can push this to a repository in Github? You can make a fork of this repository

@MyselfYangjz
Copy link
Author

I have submitted my pull request, can you review it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants