Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We shouldn't assume prov-json is too stable. #260

Open
mccalluc opened this issue May 13, 2020 · 1 comment
Open

We shouldn't assume prov-json is too stable. #260

mccalluc opened this issue May 13, 2020 · 1 comment
Labels
bug Something isn't working feature: provenance Related to the provenance graph or table

Comments

@mccalluc
Copy link
Contributor

mccalluc commented May 13, 2020

More like tech-debt than a bug, but we shouldn't assume too much about the stability of prov-json. It's a serialization of a much more flexible datastructure, and while I don't expect it to change, tying ourselves too tightly too it is like parsing xml with regexes. The easiest thing to point at are the colon-prefixes: These could be changed, without changing the semantics... but it would break us.

Some options:

  • See if some other part of the response has the information we need. (best?)
  • Propose additions to response which would provide what we need.
  • Pull in a real prov-json library. (worst?)

cc @john-conroy

@mccalluc mccalluc added the bug Something isn't working label May 13, 2020
@john-conroy
Copy link
Collaborator

I think we can close this?

@mccalluc mccalluc added the feature: provenance Related to the provenance graph or table label May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feature: provenance Related to the provenance graph or table
Projects
None yet
Development

No branches or pull requests

2 participants