-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PCA Approach #105
Comments
Hi @PavelJelen, Thank you for raising this. At the moment the focus is to imporve the accessability and get the repo into a strong open-source CI/CD setup. Once that is done, we can review technical details like this. Best regards |
Hello! I was trying to install the library with the official docs both in local virtual environment and in googlecolab. But it doesn't work for me because of different versions of pandas, tensorflow and other problems. I tried to install the versions that the framework requires, but it didn't work. Can you help me or do you have an updated guide to install? |
Hi @tinserrano, |
Hi,
I was reviewing a code for PCA Approach (pca_approach.py) and I was wondering about the _generate_signals function (line 197).
It says:
":param size: (float) Number of units invested in assets when opening trades. So when opening
a long position, buying (size) units of stock and selling (size) * betas units of other
stocks." (line 217)
However, if you look at line 236-238, I can see that it buys (size) for the most recent value of a specific "ticker" (line 237) and then it goes short (size) on all the values for the same "ticker" (line 238), essentially overwriting the previous line.
My understanding is that it should short all the other stocks (and not the same one) as per documentation.
Would you please shed some light on that?
Thank you
The text was updated successfully, but these errors were encountered: