Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wrong return type for IterableDataset.shard() #7297

Closed
ysngshn opened this issue Nov 22, 2024 · 1 comment · Fixed by #7304
Closed

wrong return type for IterableDataset.shard() #7297

ysngshn opened this issue Nov 22, 2024 · 1 comment · Fixed by #7304

Comments

@ysngshn
Copy link

ysngshn commented Nov 22, 2024

Describe the bug

IterableDataset.shard() has the wrong typing for its return as "Dataset". It should be "IterableDataset". Makes my IDE unhappy.

Steps to reproduce the bug

look at the source code?

Expected behavior

Correct return type as "IterableDataset"

Environment info

datasets==3.1.0
@lhoestq lhoestq mentioned this issue Dec 3, 2024
Merged
@lhoestq
Copy link
Member

lhoestq commented Dec 3, 2024

Oops my bad ! thanks for reporting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update iterable_dataset.py huggingface/datasets
2 participants
@lhoestq @ysngshn