Skip to content

Incompatibile dill version (0.3.9) in datasets 2.18.0 - 3.5.0 #7510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JGrel opened this issue Apr 14, 2025 · 5 comments
Open

Incompatibile dill version (0.3.9) in datasets 2.18.0 - 3.5.0 #7510

JGrel opened this issue Apr 14, 2025 · 5 comments

Comments

@JGrel
Copy link

JGrel commented Apr 14, 2025

Describe the bug

Datasets 2.18.0 - 3.5.0 has a dependency on dill < 0.3.9. This causes errors with dill >= 0.3.9.

Could you please take a look into it and make it compatible?

Steps to reproduce the bug

  1. Install setuptools >= 2.18.0
  2. Install dill >=0.3.9
  3. Run pip check
  4. Output:
    ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
    datasets 2.18.0 requires dill<0.3.9,>=0.3.0, but you have dill 0.3.9 which is incompatible.

Expected behavior

Pip install both libraries without any errors

Environment info

Datasets version: 2.18 - 3.5
Python: 3.11

@lhoestq
Copy link
Member

lhoestq commented Apr 15, 2025

Hi ! We can bump dill to 0.3.9 if we make sure it's deterministic and doesn't break the caching mechanism in datasets.

Would you be interested in opening a PR ? Then we can run the CI to see if it works

@JGrel
Copy link
Author

JGrel commented Apr 16, 2025

Hi!. Yeah I can do it. Should I make any changes besides dill versions?

@lhoestq
Copy link
Member

lhoestq commented Apr 16, 2025

There are probably some usage of internal functions from dill that we'll need to update in datasets

If you run pytest tests/test_fingerprint.py you should already have a good idea of what works and what doesn't.
But feel free to open a PR anyway, this way we can run the full CI and see the results

@JGrel
Copy link
Author

JGrel commented Apr 23, 2025

Hi, sorry for no response from my side. I will try to do it today.

@JGrel
Copy link
Author

JGrel commented Apr 24, 2025

Created pull request: LINK
Tried to run tests by using command you have send and got few errors:

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants