Skip to content

Commit ed10244

Browse files
authored
Fixes for release 2025.01 (#1164)
## Description Minor fixes for the 2025.01 release --------- Signed-off-by: hugsy <[email protected]>
1 parent 538c7c6 commit ed10244

File tree

4 files changed

+15
-13
lines changed

4 files changed

+15
-13
lines changed

.github/workflows/coverage.yml

+9-7
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
name: CI Coverage for PR
1+
name: Coverage
22

33
on:
44
pull_request_target:
@@ -14,16 +14,18 @@ jobs:
1414
coverage:
1515
env:
1616
PY_VER: ''
17-
runs-on: ubuntu-latest
17+
runs-on: ubuntu-24.04
1818
steps:
1919
- name: Checkout
2020
uses: actions/checkout@v4
2121
- name: Setup
2222
run: |
23-
sudo apt-get -qq update
24-
sudo apt-get -qq install -y gdb-multiarch python3-dev python3-pip python3-wheel python3-setuptools git cmake gcc g++ pkg-config libglib2.0-dev gdbserver qemu-user curl
25-
sudo python3 -m pip install --upgrade pip --quiet
26-
- name: Run test coverage
23+
export NEEDRESTART_MODE=n
24+
sudo apt-get update -qq
25+
sudo apt-get install -qq -y gdb-multiarch python3-dev python3-pip python3-wheel python3-setuptools git cmake gcc g++ pkg-config libglib2.0-dev gdbserver qemu-user curl
26+
sudo apt-get install -y python3-full
27+
28+
- name: Run coverage
2729
id: get_coverage
2830
env:
2931
ALLOWED_MARGIN: 0.01
@@ -41,7 +43,7 @@ jobs:
4143
echo "current_score=${current_score}" >> $GITHUB_OUTPUT
4244
echo "score_diff=${score_diff}" >> $GITHUB_OUTPUT
4345
44-
- name: Post comment
46+
- name: Post results
4547
uses: actions/github-script@v7
4648
with:
4749
script: |

LICENSE

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
The MIT License (MIT)
22

3-
Copyright (c) 2013-2024 crazy rabbidz
3+
Copyright (c) 2013-2025 crazy rabbidz
44

55
Permission is hereby granted, free of charge, to any person obtaining a copy
66
of this software and associated documentation files (the "Software"), to deal

README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ try to reach out for help on the Discord channel or submit an issue.
7575

7676
| Documentation |License | Compatibility | CI Tests (`main`) |
7777
|:---:|:---:|:---|--|
78-
| [![Documentation](https://github.com/hugsy/gef/actions/workflows/generate-docs.yml/badge.svg)](https://github.com/hugsy/gef/actions/workflows/generate-docs.yml) | [![MIT](https://img.shields.io/packagist/l/doctrine/orm.svg?maxAge=2592000?style=plastic)](https://github.com/hugsy/gef/blob/main/LICENSE) | [![Python 3](https://img.shields.io/badge/Python-3-green.svg)](https://github.com/hugsy/gef/) | [![CI Test for GEF](https://github.com/hugsy/gef/actions/workflows/run-tests.yml/badge.svg)](https://github.com/hugsy/gef/actions/workflows/run-tests.yml) |
78+
| [![Documentation](https://github.com/hugsy/gef/actions/workflows/generate-docs.yml/badge.svg)](https://github.com/hugsy/gef/actions/workflows/generate-docs.yml) | [![MIT](https://img.shields.io/packagist/l/doctrine/orm.svg?maxAge=2592000?style=plastic)](https://github.com/hugsy/gef/blob/main/LICENSE) | [![Python 3](https://img.shields.io/badge/Python-3-green.svg)](https://github.com/hugsy/gef/) | [![CI Test for GEF](https://github.com/hugsy/gef/actions/workflows/tests.yml/badge.svg)](https://github.com/hugsy/gef/actions/workflows/tests.yml) |
7979

8080
## Contribute
8181

gef.py

+4-4
Original file line numberDiff line numberDiff line change
@@ -3703,7 +3703,7 @@ def new_objfile_handler(evt: "gdb.NewObjFileEvent | None") -> None:
37033703
if evt:
37043704
path = evt.new_objfile.filename or ""
37053705
elif progspace:
3706-
path = progspace.filename
3706+
path = progspace.filename or ""
37073707
else:
37083708
raise RuntimeError("Cannot determine file path")
37093709
try:
@@ -4901,7 +4901,7 @@ def do_invoke(self, argv: list[str]) -> None:
49014901

49024902
try:
49034903
git = which("git")
4904-
except:
4904+
except FileNotFoundError:
49054905
git = None
49064906

49074907
if git:
@@ -11403,7 +11403,7 @@ def file(self) -> pathlib.Path | None:
1140311403
return self.remote.file
1140411404
progspace = gdb.current_progspace()
1140511405
assert progspace
11406-
fpath: str = progspace.filename
11406+
fpath: str = progspace.filename or ""
1140711407
if fpath and not self._file:
1140811408
self._file = pathlib.Path(fpath).expanduser()
1140911409
return self._file
@@ -11547,7 +11547,7 @@ def file(self) -> pathlib.Path:
1154711547
if not filename:
1154811548
raise RuntimeError("No session started")
1154911549
start_idx = len("target:") if filename.startswith("target:") else 0
11550-
self._file = pathlib.Path(progspace.filename[start_idx:])
11550+
self._file = pathlib.Path(filename[start_idx:])
1155111551
return self._file
1155211552

1155311553
@property

0 commit comments

Comments
 (0)