You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi! This is an amazing plugin which we use almost in every site, thanks!
There are a few things that are bugging me, related to compatibility with Polylang:
CPT archive page slugs need to be translated in Polylang "Strings translations" tool to exactly same as the translated archive page slug is. I'd like to find a robust solution for this, or at least give the user a reminder about this
menus do not get current-menu-item etc classes for translated archive pages, I have a small workaround for that to be put in filter_wp_nav_menu_objects function after $page_ids is set
@timiwahalahti hey sorry, haven't looked at this repo in a while! I feel that generally I prefer to keep integrations with other plugins external but ensure that there are appropriate places to hook into to make it as easy as possible. The reason is just that I don't have much time to maintain projects like this and having to test a Polylang integration too would add to that.
I'd be more than happy to add a link to a separate Polylang integration plugin on the Readme however, and if there are certain filters / actions that would make it easier to build I'm happy to accept PRs to add them.
Hi! This is an amazing plugin which we use almost in every site, thanks!
There are a few things that are bugging me, related to compatibility with Polylang:
current-menu-item
etc classes for translated archive pages, I have a small workaround for that to be put infilter_wp_nav_menu_objects
function after$page_ids
is setI'm wondering, do you accept PR's for this kind of compatibility issues or should I create a plugin for Polylang compatibility?
The text was updated successfully, but these errors were encountered: