Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable "Leave a Conversation" Notification #420

Open
mareb opened this issue Sep 25, 2024 · 5 comments · May be fixed by #427
Open

Disable "Leave a Conversation" Notification #420

mareb opened this issue Sep 25, 2024 · 5 comments · May be fixed by #427

Comments

@mareb
Copy link

mareb commented Sep 25, 2024

A user can leave a conversation. Now, some people in our community have figured out how to do this and many are using it. The result (because I am involved in a lot of conversations):

I get dozens of new messages with the message “XY has left the conversation” every day.
Can I generally disable this kind of message? I couldn't find any configuration for this.

@luke- luke- changed the title Leave a Conversation does create a new message Disable "Leave a Conversation" Notification Sep 25, 2024
@ArchBlood ArchBlood linked a pull request Nov 5, 2024 that will close this issue
@luke-
Copy link
Contributor

luke- commented Nov 5, 2024

I would dislike adding an option to disable this indicator.

Maybe we could set it up so that this message is “quiet” and does not trigger a notification or push the conversation to the top.

@ArchBlood
Copy link

I would dislike adding an option to disable this indicator.

Maybe we could set it up so that this message is “quiet” and does not trigger a notification or push the conversation to the top.

This would probably be best to be handled through the JavaScript then, which I'm not sure that I'd be the best to implement such a function, and overall should probably be introduced within the core of HumHub rather than being a module specific function so that it could possibly be used for other "annoying" notifications.

@luke-
Copy link
Contributor

luke- commented Nov 5, 2024

I think we should rather intercept it on the backend/PHP side so that no notification is triggered at all, instead of hiding it with JS.

@ArchBlood
Copy link

I think we should rather intercept it on the backend/PHP side so that no notification is triggered at all, instead of hiding it with JS.

I'd like to note that #427 currently does this but only for Joined & Left messages for the mail module specifically, but when it comes to the notification count side it is not handled this way, it is handled through JavaScript or am I mistaken?

@luke-
Copy link
Contributor

luke- commented Nov 6, 2024

I think we should rather intercept it on the backend/PHP side so that no notification is triggered at all, instead of hiding it with JS.

I'd like to note that #427 currently does this but only for Joined & Left messages for the mail module specifically, but when it comes to the notification count side it is not handled this way, it is handled through JavaScript or am I mistaken?

For me, it looks like the notices are simply being skipped in PR. I would still show them in the message, just quietly. The counter value should come from PHP and be pushed via JS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants