-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IX] Add support for "empty" being the labeled data #6979
Comments
In the stats and filters this becomes a labeled data. So:
So I guess we don't need to modify the stats UI, but just make sure that the backend is placing the right data in the right place. In the table, maybe since the option to accept a suggestion exists in the table, we should also have the option to accept an "empty" value as the correct value and labeled data. For the sake of simplicity we could skip this change for now and allow to set the "empty" value only from the side panel. Where we definitely need to be able to set the "empty" value is in the side panel. |
@txau given that both can have an empty state, i guess the only way to filter through them is by adding a nested filter to Match and Mismatch (opening the possibility for us adding more options of granular filtering) but will also mean adding a "partial" state for the checkboxes and maybe a "collapse/expand" action to the main one at some point. ![]() ![]() |
I think we don't need to modify the filters. They are ok as they are, if the property is LABELED as empty, it may match or mismatch, we don't need to differentiate the empty status in filters. What we need is a way to set and check this value in the form. It was suggested to have an extra option in the multiselect that is a fixed option saying "empty". But this is obfuscated. I think we need a more obvious and quick way for handling the empty value. |
This change also affects the contract with the service. We want to be explicit about whether a value is empty and whether the suggested prediction is empty. My suggestion for passing this information back and forth to the service is as follows: LabeledData:
Suggestion:
|
@gabriel-piles I think this contract is accepted by the backenders |
This should be displayed in the Suggestions column and also in the Stats & Filter Panel.
FIX BUG:
When accepting a SELECT type suggestion, if the suggestion is empty the server returns an error
Id is invalid: name_of_the_tesauri
because it tries to find the suggested value, which is nothing in the thesauri. This bug can now only happen when bulk accepting.The UI should allow to individually accept SELECT, TEXT and NUMERIC suggestions with empty values.
The text was updated successfully, but these errors were encountered: