Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Make random changes" button breaks initVideo #230

Open
milangress opened this issue Jan 12, 2023 · 3 comments
Open

"Make random changes" button breaks initVideo #230

milangress opened this issue Jan 12, 2023 · 3 comments

Comments

@milangress
Copy link

the "make random changes" button in the editor sometimes breaks functions that use text like initVideo and initImage

that results in values like:

s0.initVideo(NaN);

I guess if the value is not a number then it should not changes it?

@flordefuego
Copy link
Member

what about just commenting s0.initVideo() once it's loaded? If you want to play with random button for live, once image it's loded I guess you don't need to call that function everytime

@geikha
Copy link
Member

geikha commented Jan 19, 2023

nah but it makes sense to try and make some exceptions if the randomizer code allows it. I'll look into it for a bit during the week. nice catch

@milangress
Copy link
Author

Thanks, Flor for the idea of the quick fix! It helps. But I had the case when I was sending students code and asked them to explore it, so I would also like to reduce the complexity a bit for people with less coding experience. So a change to the randomizer code would be appreciated :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants