Updating to std::future::Future

[seanmonstar]

With std::future::Future stabilizing in Rust 1.36, it is a goal to upgrade from futures@0.1 to std::future::Future in the next breaking change (hyper@0.13).

---

Status:

• Update hyper lib to std::future Update to std::future #1836
• Update doc tests to std::future Update doc tests for 0.13 #1850
• Update examples to std::future Update the examples for 0.13 #1849
• Update tests to std::future Re-enable tests for 0.13 #1848
• Update h2 to std::future Update h2 to std::future #1851

[davidbarsky]

I might be missing something, but is there a tracking issue on Tower to support 0.3 futures?

[dekellum]

You say you are just considering it, but would TLS (Thread Local Storage, I presume) play well with Tokio's multi-threaded executor and, for example with conditional calls to tokio_threadpool::blocking in (Body) Streams and Sinks?

[seanmonstar]

That should be fine. When calling poll methods, we'd still need to materialize the Context before doing so, so there'd be no relying on other libraries keeping things on the same thread. It's more just wanting to reduce the noise of having to pass a Context to many methods of proto::h1::Conn that don't always need it, but might poll the IO.

[seanmonstar]

Most of the dependencies needed are updated in tokio's std-future branch. Disabling tokio-threadpool and h2 should hopefully be enough to start a branch here.

It's probably not worth figuring out some TLS Context thingy, and just passing the argument everywhere.

[softprops]

https://blog.rust-lang.org/2019/07/04/Rust-1.36.0.html

[seanmonstar]

#1836 is the PR for this, it's pretty close. Most things work (minus h2), and I have some local work to remove much of added unsafety, which I hope to have ready Monday. I'll likely merge that into master with docs and tests disabled, to allow those things to be worked on in parallel.

[seanmonstar]

Master is now tracking 0.13, and #1836 was merged into it. It lacks HTTP2 support, an unsafe pin audit, and all the tests and examples were disabled, but hopefully those can be worked on in parallel.