Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit schema file to the repo? #5189

Open
mversic opened this issue Oct 23, 2024 · 1 comment
Open

Commit schema file to the repo? #5189

mversic opened this issue Oct 23, 2024 · 1 comment
Labels
question Further information is requested

Comments

@mversic
Copy link
Contributor

mversic commented Oct 23, 2024

This file can be downloaded as a workflow artifact. And if not then anyone can generate it locally. Do we need to keep it committed to the repo?

@mversic mversic added the question Further information is requested label Oct 23, 2024
@mversic mversic moved this to Backlog in Iroha Oct 23, 2024
@s8sato
Copy link
Contributor

s8sato commented Oct 30, 2024

Basically it would depend on how frequently schema is referenced in SDK development. However, I personally don't think it necessarily needs to be tracked as the correctness of schema is guaranteed by iroha_schema_gen::tests (everyone still need to remember to include new types in the list)

To detect api-changes, we could rely on iroha_schema_gen instead of schema.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants