Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review use of expect/panic/assert/unwrap across the hyperlight codebase #320

Open
simongdavies opened this issue Mar 4, 2025 · 0 comments · May be fixed by #325
Open

Review use of expect/panic/assert/unwrap across the hyperlight codebase #320

simongdavies opened this issue Mar 4, 2025 · 0 comments · May be fixed by #325
Assignees
Labels
Milestone

Comments

@simongdavies
Copy link
Contributor

Since hyperlight is a library the use of expect/panic/assert/unwrap especially in release builds is problematic since it use implies that we are happy to terminate the process, in most cases these usages should be turned into errors returned to the host program, the only cases where we should expect/panic/assert/unwrap are where we detect out of bounds memory access attempts or actions that would corrupt data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

2 participants