Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DirectX Porting Demo #1

Open
alihanpehlivan opened this issue Jan 10, 2021 · 3 comments
Open

DirectX Porting Demo #1

alihanpehlivan opened this issue Jan 10, 2021 · 3 comments

Comments

@alihanpehlivan
Copy link

Currently demo is only with OpenGL... Are you planning to add any DirectX porting demo too?

@hypernewbie
Copy link
Owner

Sorry, no DX demos planned for now :)
Would be happy to take one as contribution!

Not too much difference; one gotcha is that sample center is different vs openGL, so would need to offset by half a pixel.

@alihanpehlivan
Copy link
Author

Thank you for your answer, I am planning to implement your library to my custom engine, will start working on it soon. Hopefully if everything goes well, I will definitely contribute :)

And also a small note, if you can add more explanatory comments both in library and demo piece of code it would be really helpful for other people too... Library and demo in it's current state is very hard to read and all code is very clamped it's almost like you did not want other programmers to read it easily :D. I had to use clang-format on the code to read it easily. My eyes almost bled.

Ref: Google C++ Style Guide

Cheers!

@hypernewbie
Copy link
Owner

haha agreed!

sorry yeah demo is hastily put together. I'll format that better!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants