Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove - while setting collapsed constraints for MessageViewController #211

Open
Narek1994 opened this issue Jul 7, 2022 · 0 comments
Open

Comments

@Narek1994
Copy link

Narek1994 commented Jul 7, 2022

Sorry for not openning PR, I made a lot of changes, so dont want to push it here :)

private func makeCollapsedConstraints() -> [NSLayoutConstraint] {
    return [
      messageView.bottomAnchor.constraint(equalTo: view.bottomAnchor),
      messageView.leadingAnchor.constraint(equalTo: view.leadingAnchor),
      messageView.trailingAnchor.constraint(equalTo: view.trailingAnchor),
      messageView.heightAnchor.constraint(
        equalToConstant: hideFooterView ? 0 : -BarcodeScannerViewController.footerHeight
      )
    ]
  }

Here I think -BarcodeScannerViewController.footerHeight should be BarcodeScannerViewController.footerHeight height can not be negative.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant