Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable users to change their own role on the /groups/{pubid}/edit/members page #9136

Open
seanh opened this issue Nov 28, 2024 · 0 comments
Open

Comments

@seanh
Copy link
Contributor

seanh commented Nov 28, 2024

See also: #9135

Currently users can't use the Members table on the /groups/{pubid}/edit/members to change their own role: there is a row in the table for the user's own membership, but the role in this table row isn't editable.

Make the role in the user's own table row editable so that users can use the table to edit their own role.

Notes:

  • This should be a frontend-only change: the backend API for editing roles already allows a user to edit their own role.
  • Downgrading your own role has consequences for what you can and can't do in the group and (unlike when changing someone else's role) cannot be undone: once you've downgraded yourself you can't upgrade yourself back to your old role. No user can upgrade their own role. Before we allow a user to downgrade their own role we need to show a warning dialog to this effect, importantly including the fact that this can't be undone.
  • Changing your own role changes what actions you can take against every other member in the group, so after changing the user's own role the frontend will have to call the get-group-members API to re-fetch all displayed members and update their rows in the table.
  • This interacts with pagination (Add pagination to the get-group-members API #9133): if the table is paginated and the UI is currently displaying page n, we may want to maintain that state and stay on page n even after re-fetching all the members.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant