Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a response body to the add-group-member API #9141

Closed
seanh opened this issue Nov 28, 2024 · 0 comments · Fixed by #9188
Closed

Add a response body to the add-group-member API #9141

seanh opened this issue Nov 28, 2024 · 0 comments · Fixed by #9188
Assignees
@seanh

Comments

@seanh
Copy link
Contributor

seanh commented Nov 28, 2024 •
edited
Loading

See also: #9140

The edit-group-member API responses with a 200 OK containing the updated membership in the response body, but the add-group-member API just responds with a 204 Success with no body.

Change the add-group-member API's response to be a 200 OK with the newly added membership in the response body, the same as the edit-group-member API.

Don't forget to update the docs at https://h.readthedocs.io/en/latest/api-reference/v1/#tag/groups/paths/~1groups~1{id}~1members~1{user}/post.
@seanh seanh mentioned this issue Nov 28, 2024
Closed
seanh added a commit that referenced this issue Dec 5, 2024
@seanh
Add response body to add-member API
1d484f3 
Change the add-group-membership API's response from a 204 No Content to
a 200 OK with a JSON representation of the added membership as the body.

Fixes #9141
@seanh seanh mentioned this issue Dec 5, 2024
Merged
seanh added a commit that referenced this issue Dec 6, 2024
@seanh
Add response body to add-member API
d064db2 
Change the add-group-membership API's response from a 204 No Content to
a 200 OK with a JSON representation of the added membership as the body.

Fixes #9141
seanh added a commit that referenced this issue Dec 6, 2024
@seanh
Add response body to add-member API
2ebfb06 
Change the add-group-membership API's response from a 204 No Content to
a 200 OK with a JSON representation of the added membership as the body.

Fixes #9141
@seanh seanh self-assigned this Dec 6, 2024
seanh added a commit that referenced this issue Dec 12, 2024
@seanh
Add response body to add-member API
c649dc9 
Change the add-group-membership API's response from a 204 No Content to
a 200 OK with a JSON representation of the added membership as the body.

Fixes #9141
seanh added a commit that referenced this issue Jan 7, 2025
@seanh
Add response body to add-member API
9e36f77 
Change the add-group-membership API's response from a 204 No Content to
a 200 OK with a JSON representation of the added membership as the body.

Fixes #9141
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seanh seanh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add response body to add-member API hypothesis/h
1 participant
@seanh