-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disarmed by Failsafe when the aircraft should entered have RTH #10483
Comments
I'm One of the people mentioned in the post. VID-20240408-WA0030.1.mp4To be honest i never found the plane so i never been able to check the log and if i really setted everything correct, especially the failsafe page. once of the possible explanation still be i selected "DROP" instead of "RTH" but i still can't be sure about it. |
@ELLIOTfpv11 could you please answer the bullet point questions. Answering as much as you can. |
I think there's a bug that explains why it disarms when it should be doing an emergency landing, defaults to Drop It because the failsafe emergency landing isn't initialised correctly when the RTH fails. Doesn't explain why the RTH is failing and defaulting to Emergency Landing instead though. |
I had this incident and the video in facebook is from my MiniTalon Model. I had flown this Model to the max distance of 7-8Km and to the altitude of 1Km before this incident. I had just updated my crossfire micro TXv2 and nano Rx from v6.09 to v6.36. My model is running INAV 6.1.1 and failsafe set to RTH, a perfect takeoff with autolaunch and when I took control of the model at 500m distance and 300 m height immediatly failsafe was triggered,it looks like I lost Rx link (I suspected Rx link bcoz the summary OSD shows MIN LQ: 26%)and the got DISARMED mid flight, which is strange as I have set failsafe to RTH. Luckly my spotter was having the model LOS and guided to safe landing.Unfortunately I lost the video link also when failsafe was trigger as I was not facing the googles in correct direction. INAV Firmware version: INAV 6.1.1 |
@egpurush thank you for that. But could you please add the video here. There are a few developers who don't use Facebook. |
INAV Firmware version: INAV 7.0 or 6.1, i can't be sure |
I think I can see what the problem is if the failsafe happens during launch. Launch mode isn't being cancelled properly when the failsafe occurs which prevents the switch to RTH flight mode before failsafe checks the RTH state and decides it's failed causing failsafe to default to Emergency Landing instead ... which then defaults to Drop it because the emergency landing wasn't initialised correctly. So a couple of bugs it would appear. In the log above the plane is still in launch mode when the failsafe occurs, 0.7s after the Rx signal is shown as lost. So this would tie in with the above bug. However, this doesn't explain the other disarm in the 2nd post above when Launch mode wasn't active although it's not clear if RTH was actually set in that case. |
With the 2nd example (13km away). There is no diff or log. So we don't actually know what was set. Speaking on Facebook. He believes that it was set to RTH. But then there is no guarantee. Default is drop. So it could have been overlooked in the setup. It sounds like there is something that can be fixed in the case of FS during auto launch. So that's a positive. |
I've fixed the RTH issue including have it fall back to Emergency Landing if RTH fails rather than falling back to Drop it. However, it still disarms when you have it set to Land and you get Failsafe during launch. Works OK once Launch has ended but not during Launch which is a bit strange ... need to work out why because it should really just behave the same way as RTH but Land instead. Edit: OK fixed the Emergency Landing issue also. Guess not many people have Failsafe's during launch because these bugs have been there for a long time. |
Here is the youtube link https://www.youtube.com/watch?v=9Fq75k-Zqnc |
Testing in HITL shows that if |
@MrD-RC did you replicate the issue or anyone else so we can verify if the fix works? |
Not the autolaunch issue. Only confirmed what happens with drop + failsafe. |
Alright will do some tests in the evening. |
I tested the fix in HITL and it worked as expected. But always better if someone else can double check. |
There have been a couple of reports where people have experienced a failsafe and the aircraft immediately disarms. An example of this can be found on the INAV Fixed Wing Group on Facebook. In the example, the aircraft autolaunches. As soon as it exits autolaunch, there is a failsafe. But instead of actioning RTH. The aircraft disarms. This aircraft was running TBS Crossfire, and had been working fine before. The only change being an update of the Crossfire firmware. However, there has also been a similar incident with an aircraft using ELRS. Both times the failsafe procedure was set to RTH.
It is unknown if this is an INAV issue, or related to the link. This is an information compilation at the moment. To try and find some correlation on what is happening.
If this has happened to you. Please could you reply to this issue giving as much detail as possible on your setup and what happened. If possible please include the following details (copy and paste this list as a template if it's easier):
diff all
from the flight controllerIf you cannot provide the DVR with OSD. Please include a description of the flight. If you could not recover the aircraft. A backup diff from before the flight will be fine. If you're not sure how to add your diff as a text file. Check out this video.
Example form:
diff all
from the flight controller <diff.txt>The text was updated successfully, but these errors were encountered: