Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<Modal /> and <Dialog /> Components pushed behind floating windows #1032

Open
PondPackMan2023 opened this issue Sep 16, 2024 · 1 comment
Open
Assignees
Labels
bug Something isn't working

Comments

@PondPackMan2023
Copy link

Describe the bug

I have a widget that uses the component to display a dialog to the user to enter some input. With 4.16.5, the dialog is pushed behind the window it was opened. The widget is a floating window my electron app.

This is a regression. I am pretty sure that 4.16.4 did not have this issue.

To Reproduce

No response

Expected Behavior

The or window should stay at the very top of the UI.

Screenshots

Menu item "Add Return Period" opens a dialog.
image
No window appears:
image
If you shrink the size of the floating window, you'll see the modal dialog:
image

Desktop (please complete the applicable information)

iTwin.js: 4.9.0-dev.22
iTwinUI: 3.14.2
AppUI: 4.16.5
React: 17.0.2
Node.js: 20.9.0
Electron: 29.1.0

Additional context

No response

@PondPackMan2023 PondPackMan2023 added the bug Something isn't working label Sep 16, 2024
@GerardasB GerardasB self-assigned this Sep 18, 2024
@GerardasB
Copy link
Collaborator

I'll need more details for this issue. Can not reproduce in our test-app.
Rendering a portalled Dialog or Modal components of iTwinUI seems to work fine from AppUI widgets https://github.com/iTwin/appui/blob/64a540e8675869d62f777da8f36998993cc72b24/apps/test-app/src/frontend/appui/frontstages/ElementStacking.tsx#L234C8-L234C18
You can play around with it in AppUI test-app at http://localhost:3000/blank?frontstageId=element-stacking

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants