Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start using CSS modules #825

Open
GerardasB opened this issue May 6, 2024 · 1 comment
Open

Start using CSS modules #825

GerardasB opened this issue May 6, 2024 · 1 comment
Labels
breaking-change css Issue related to CSS react Issue related to React

Comments

@GerardasB
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

Some of the consumers are still targeting internal AppUI class names. Utilizing CSS modules would prevent that.

Describe the Solution you'd like

Start using CSS modules in AppUI components. This can be an incremental effort since some of the components target elements outside of the component scope.

Describe alternatives you've considered

No response

Additional context

Our consumers are already using build tools that support building SCSS files.
Most bundlers should support CSS modules out of the box, however, it would be safer to introduce CSS modules with a new major release.

@GerardasB GerardasB added css Issue related to CSS react Issue related to React labels May 6, 2024
@GerardasB GerardasB added this to the AppUI 5.0 milestone May 6, 2024
@GerardasB GerardasB changed the title Start using CSS modules Start using CSS modules May 6, 2024
@GerardasB
Copy link
Collaborator Author

GerardasB commented Oct 1, 2024

We will not include this feature in AppUI 5.0 because it introduces additional, non-standard, and bundler-specific requirements for our users. Ideally, CSS should be delivered separately or loaded through standard JavaScript methods. While CSS modules can be utilized as an internal build step, this approach falls outside the scope of this release. +@mayank99

@GerardasB GerardasB removed this from the AppUI 5.0 milestone Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change css Issue related to CSS react Issue related to React
Projects
None yet
Development

No branches or pull requests

1 participant