Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type test all files in itwinui-react #1561

Closed
r100-stack opened this issue Sep 12, 2023 · 1 comment
Closed

Type test all files in itwinui-react #1561

r100-stack opened this issue Sep 12, 2023 · 1 comment
Assignees
Labels
maintenance Related to development or technical debt or chores

Comments

@r100-stack
Copy link
Member

From #1514 (comment).
Related threads: #1514 (comment), #1514 (comment)

Instead of having tsc in build just type check the files that will be built, we should type check all files. By all files, I mean even the unit test files.

This is because unit tests currently pass even with type errors in them. So there is no way of detecting some very specific type error if it only occurs in the unit test files.

@r100-stack r100-stack added the maintenance Related to development or technical debt or chores label Sep 12, 2023
@r100-stack r100-stack mentioned this issue Sep 12, 2023
7 tasks
@r100-stack r100-stack self-assigned this Sep 13, 2023
@mayank99 mayank99 mentioned this issue Sep 21, 2023
18 tasks
@mayank99
Copy link
Contributor

Folding into #1571 for ease of tracking.

@mayank99 mayank99 closed this as not planned Won't fix, can't repro, duplicate, stale Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Related to development or technical debt or chores
Projects
None yet
Development

No branches or pull requests

2 participants