Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website Content Organization #1393

Merged
merged 16 commits into from
Jul 10, 2023
Merged

Website Content Organization #1393

merged 16 commits into from
Jul 10, 2023

Conversation

marashad001
Copy link
Contributor

@marashad001 marashad001 commented Jul 5, 2023

Changes

#941

Reorganizing each website doc to follow this order:

Title
Paragraph
Demo
Paragraph
Demo
etc.

(see #1180)

Testing

N/A

Docs

All website documents will be re-ordered according to the the Title, Paragraph, Demo format.

Copy link
Contributor

@gretanausedaite gretanausedaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was the change in side navigation intentional?
image

@marashad001
Copy link
Contributor Author

marashad001 commented Jul 5, 2023

Was the change in side navigation intentional? image

No, it was a mistake. I just fixed it, thank you

@marashad001 marashad001 marked this pull request as ready for review July 7, 2023 20:00
@marashad001 marashad001 requested review from a team as code owners July 7, 2023 20:00
@marashad001 marashad001 requested review from mayank99 and adamhock and removed request for a team July 7, 2023 20:00
Copy link
Contributor

@mayank99 mayank99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Make sure to clean up PR description and title, as there are no styling changes anymore.

@marashad001 marashad001 changed the title Website Content Spacing and Organization Website Content Organization Jul 10, 2023
@@ -11,6 +11,8 @@ import PropsTable from '~/components/PropsTable.astro';
import LiveExample from '~/components/LiveExample.astro';
import * as AllExamples from 'examples';

A series of selectable tile components that behave like [radio button](radio). You may include icons to help make each tile more identifiable.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would move this to the description: section on line 3 or at least move the first sentence there

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cut and paste the whole thing or copy it over to line 3?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cut and paste

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Actually I'm mistaken. It appears we can't link the Radio page when using this syntax in the description section. Therefore, what you had previously is fine. Sorry!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good :)

@marashad001 marashad001 added this pull request to the merge queue Jul 10, 2023
Merged via the queue into dev with commit 8192464 Jul 10, 2023
@marashad001 marashad001 deleted the malik/docs-vertical-spacing branch July 10, 2023 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants