Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Header): Added htmlName prop to HeaderButton #1457

Merged
merged 3 commits into from
Jul 28, 2023
Merged

fix(Header): Added htmlName prop to HeaderButton #1457

merged 3 commits into from
Jul 28, 2023

Conversation

adamhock
Copy link
Contributor

Changes

Added htmlName prop to the HeaderButton subcomponent which handles the native name attribute in <button>.

Closes #971

Testing

Tested by setting htmlName prop in website example and looking for the name attribute in the resulting HTML

Docs

Changeset added

@adamhock adamhock added this to the React 3.0 milestone Jul 28, 2023
@adamhock adamhock self-assigned this Jul 28, 2023
@adamhock adamhock requested review from a team as code owners July 28, 2023 18:38
@adamhock adamhock requested review from mayank99 and LostABike and removed request for a team July 28, 2023 18:38
mayank99
mayank99 approved these changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@mayank99 mayank99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I would have like to refactor the Header components at some point (#1444) so that we don't even have a name prop, but this is good enough for now.

@adamhock adamhock added this pull request to the merge queue Jul 28, 2023
Merged via the queue into dev with commit 4709b2f Jul 28, 2023
@adamhock adamhock deleted the adam/header-button-name branch July 28, 2023 21:30
@imodeljs-admin imodeljs-admin mentioned this pull request Jul 28, 2023
Merged
@imodeljs-admin imodeljs-admin mentioned this pull request Oct 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LostABike LostABike LostABike approved these changes

@mayank99 mayank99 mayank99 approved these changes

Assignees

@adamhock adamhock

Labels
None yet
Projects
None yet
Milestone
React 3.0
Development

Successfully merging this pull request may close these issues.

v3: Header button name & description prop renamed
3 participants
@adamhock @mayank99 @LostABike