Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Surface a11y fix #1500

Merged
merged 11 commits into from
Aug 18, 2023
Merged

Surface a11y fix #1500

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
206db45
initial push
xman343 Aug 16, 2023
233061b
settings button label added
xman343 Aug 16, 2023
e1f1243
Divider as ='li'
xman343 Aug 17, 2023
f19c745
surface and links made tab accessible
xman343 Aug 17, 2023
688d9ae
Merge branch 'dev' into xander/surface-a11y-fix
xman343 Aug 17, 2023
85a4141
links keyboard accessible
xman343 Aug 17, 2023
4d5a8fa
Merge branch 'xander/surface-a11y-fix' of https://github.com/iTwin/iT…
xman343 Aug 17, 2023
5ad46f2
Merge branch 'dev' into xander/surface-a11y-fix
xman343 Aug 17, 2023
0a2a018
surface re-labelling by id
xman343 Aug 18, 2023
40d74dc
id update
xman343 Aug 18, 2023
aab4ea1
list converted to divs
xman343 Aug 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/Surface.headerfooter.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ export default () => {
<Text variant='subheading' as='h2'>
Custom surface
</Text>
<IconButton styleType='borderless'>
<IconButton label='Settings' styleType='borderless'>
<SvgSettings />
</IconButton>
</Flex>
Expand Down
37 changes: 21 additions & 16 deletions examples/Surface.nopadding.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,44 +16,49 @@ export default () => {
return (
<Surface elevation={3} style={cardStyle}>
<Surface.Header>
<Text variant='subheading' as='h2'>
<Text id='surface-header' variant='subheading' as='h2'>
Surface with overflow & no body padding
</Text>
</Surface.Header>
<Surface.Body isPadded={false}>
<Surface.Body
tabIndex={0}
role='group'
aria-labelledby='surface-header'
isPadded={false}
>
<Flex flexDirection='column' style={{ flex: '1' }}>
<ul
<div
style={{
width: '100%',
listStyle: 'none',
margin: 0,
padding: 0,
}}
>
<li style={listStyle}>
<div style={listStyle}>
<Anchor>Daily log</Anchor>
</li>
</div>
<Divider />
<li style={listStyle}>
<div style={listStyle}>
<Anchor>Inspections</Anchor>
</li>
</div>
<Divider />
<li style={listStyle}>
<div style={listStyle}>
<Anchor>Issues</Anchor>
</li>
</div>
<Divider />
<li style={listStyle}>
<div style={listStyle}>
<Anchor>Observations</Anchor>
</li>
</div>
<Divider />
<li style={listStyle}>
<div style={listStyle}>
<Anchor>RFIs</Anchor>
</li>
</div>
<Divider />
<li style={listStyle}>
<div style={listStyle}>
<Anchor>Weather delay notices</Anchor>
</li>
</ul>
</div>
</div>
</Flex>
</Surface.Body>
</Surface>
Expand Down