Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove scrollbar styles from docs #1673

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Conversation

mayank99
Copy link
Contributor

@mayank99 mayank99 commented Nov 6, 2023

Changes

not sure why these were added in the first place; the default scrollbars work fine.

my guess is the site was made before we had scoped styling support (iui-root), so iTwinUI scrollbars may have been messing up docs scrollbars, but now we are running into the opposite issue (#941 (comment), #1656 (comment)), so it's better to just use defaults.

Testing

tested that default scrollbars are appearing ok

Docs

n/a

@mayank99 mayank99 self-assigned this Nov 6, 2023
@mayank99 mayank99 requested review from a team as code owners November 6, 2023 18:17
@mayank99 mayank99 requested review from r100-stack and removed request for a team November 6, 2023 18:17
@r100-stack r100-stack mentioned this pull request Nov 6, 2023
Copy link
Member

@r100-stack r100-stack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that the default website scrollbars look alright on Edge, Chrome, and Firefox. Also confirmed that #1656 (comment) is fixed with this PR. 👍

@mayank99 mayank99 merged commit 6e220d8 into main Nov 6, 2023
15 checks passed
@mayank99 mayank99 deleted the mayank/website-scrollbars branch November 6, 2023 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants