Bugfix/missing peerdeps #714
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…encies but are required by the map-layers package at runtime.
a-gagnon
requested review from
mdastous-bentley,
eringram and
a team
as code owners
aruniverse
reviewed
Dec 15, 2023
|
@a-gagnon This is old and no one approved...does it need additional update before we can complete it? |
Haven't played with the app since then, but those should really be deps. I think it's fine to approve. |
aruniverse
reviewed
Aug 28, 2024
| "changes": [ | ||
| { | ||
| "packageName": "@itwin/map-layers", | ||
| "comment": "Some packages were pulled as devDependency when they really should be direct dependencies", |
There was a problem hiding this comment.
Suggested change
| "comment": "Some packages were pulled as devDependency when they really should be direct dependencies", | |
| "comment": "Updated dependencies", |
| @@ -38,6 +38,9 @@ | |||
| "dependencies": { | |||
| "@itwin/itwinui-icons-color-react": "^2.1.0", | |||
| "@itwin/itwinui-icons-react": "^2.6.0", | |||
| "@itwin/itwinui-react": "^2.11.2", | |||
| "@itwin/itwinui-variables": "^2.0.0", | |||
| "@itwin/map-layers-formats": "^4.1.2", | |||
There was a problem hiding this comment.
why is this a direct dep? is this dep pure / has no side effects?
if its not, needs to be dev + peer dep
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing peerDependencies that are required at runtime by the map-layers package.Besides
typeimports, anything that is used by the package should be a directdependency, or be in bothdevDependencyandpeerDependency.devDependenciesto directdependenciesFound the problem when adding the @itwin/map-layers package to my test-app. I didn't get a warning for missing peerDependency, but it complained about missing
@itwin/map-layers-formatsat build time.