Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: optimize for trade rebalance #61

Open
a-m-s opened this issue Nov 28, 2023 · 6 comments
Open

feature request: optimize for trade rebalance #61

a-m-s opened this issue Nov 28, 2023 · 6 comments

Comments

@a-m-s
Copy link

a-m-s commented Nov 28, 2023

The next version of Minecraft will rework the villager trading system so that obtaining enchanted books won't be quite so "broken". It'll require more exploration and such, but ultimately it'll be easier to get second-rate enchantments from the RNG. First-rate enchantments will be impossible to buy, but will be discoverable in chests and via fishing and enchantment tables.

It would be cool if this calculator could suggest "optimal" combinations of only the tradable enchantments. It'll require combining some similar books and presumably the work penalty will exclude the possibility of maximizing everything that way, so some guidance for what to prioritize might be helpful.

This feature might include a visual indication of what can be traded, UI elements for combining certain books (vs. including book acquired elsewhere), possibly a free selection that finds how to achieve it with the tradable books, and maybe even modes like "max damage", "max protection", "max speed" that make intelligent optimal selections.

@cph101
Copy link
Contributor

cph101 commented Nov 30, 2023

Unfortunately, this might be extremely challenging to implement. I think the best call is probably using React and compiling it to standard web languages, as we’d need a completely new GUI in order to achieve this.

PS: Cal, I’ll create a repo for this on my account, as it’ll be a massive change, so perhaps it would require a second site, but we’ll see..

@cph101
Copy link
Contributor

cph101 commented Nov 30, 2023

Oh I forgot to mention, this will also patch issue #12

@jmarcinik3
Copy link
Contributor

@cph101 Yo, I helped with the algorithm for Cal's calculator. It can do arbitrary combinations of lower-level books and multiple enchantments. I made a working version that does exactly this few months ago! We can use this as a starting point: Source and Pages. My aesthetics aren't very great, but the calculator is functional. Let me know if you wanna help out with it, I would be interested in improving it

@cph101
Copy link
Contributor

cph101 commented Dec 4, 2023

@jmarcinik3 Sounds good! I rewrote a lot of the UI system on another repo, so perhaps we should copy the [script] files over to mine instead? (I’ll add you as a contributor)

@jmarcinik3
Copy link
Contributor

@cph101 that sounds good to me, we can transfer to your repo. I think the hardest part is figuring out how to structure a user-friendly UI, because there are a lot a possible inputs. We can discuss the layout on your repo... or whether you had a vision for it in mind already

@cph101
Copy link
Contributor

cph101 commented Dec 4, 2023

@jmarcinik3 Do you have a discord? It might be easier than discussing on a github issue - my usertag is cph101

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants