Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change <settingsfile>.json to <settingsfile>.json.example #224

Open
rakiru opened this issue Oct 24, 2015 · 4 comments
Open

Change <settingsfile>.json to <settingsfile>.json.example #224

rakiru opened this issue Oct 24, 2015 · 4 comments

Comments

@rakiru
Copy link
Collaborator

rakiru commented Oct 24, 2015

Or something like that. It's a pain when you're messing with config files that are in version control. The game could look for whatever.json, then if that's not found look for whatever.json.example and copy that to whatever.json.

@iamgreaser
Copy link
Owner

I'm all for this. It'd probably have to take place in the launcher when first launched as the permissions are loosened on clsave/pub/... As for the server, we may have to just leave it at svsave/pub/server.json and suggest using the --server=svsave/pub/whatever/foo.json command-line argument... or we could loosen the path restrictions for the server files as well in launcher mode.

@rakiru
Copy link
Collaborator Author

rakiru commented Oct 25, 2015

Can't they create files in those folders anyway? I thought that was the point of pub/?

@iamgreaser
Copy link
Owner

pub/ is for reading, not writing - the reason being that if someone runs a dodgy mod it can clobber pub/. Hence why vol/ is there.

@rakiru
Copy link
Collaborator Author

rakiru commented Oct 25, 2015

Ah right, yeah, of course. It should be fine being in the launcher then. The build server could perhaps copy them across too, since it's only really an issue for people grabbing them from git.

As for the server, yeah, command-line arg is fine. We provide a few sample server configs anyway, rather than just one single base.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants