Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify relationship with elm-units etc. #108

Open
ianmackenzie opened this issue Sep 17, 2019 · 3 comments
Open

Clarify relationship with elm-units etc. #108

ianmackenzie opened this issue Sep 17, 2019 · 3 comments

Comments

@ianmackenzie
Copy link
Owner

Do a pass through the docs and point out where types/modules come from other packages; may also be worth adding a section to the README like "Relationship to other packages" or similar.

@ianmackenzie
Copy link
Owner Author

@dimpase
Copy link

dimpase commented Nov 4, 2020

Note that the "Using the package" instructions in https://package.elm-lang.org/packages/ianmackenzie/elm-geometry/latest/ don't work out of the box, as elm-units is not in direct dependencies after elm install ianmackenzie/elm-geometry mentioned just before that section.

A clarification would be great, as this is perhaps the first code using elm-geometry people might try (and get an error due to a missing dependency).

@ianmackenzie
Copy link
Owner Author

Good point! I've updated the README so that at least that is clear, but there probably still needs to be a more thorough review at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants