Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework scanner reset behavior #25

Closed
ianprime0509 opened this issue Oct 15, 2023 · 1 comment
Closed

Rework scanner reset behavior #25

ianprime0509 opened this issue Oct 15, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@ianprime0509
Copy link
Owner

If Scanner returns a token, there is only one state where it cannot simply be reset with no resulting subsequent token after the caller is done with the token: pi_maybe_end. It would be a great simplification opportunity if this could be omitted, and the scanner could just be cleanly reset before starting on the next token in TokenReader.

This is also a reminder to me to double-check on the similar CDATA ending states, which look like they may be handled incorrectly, but I need to confirm (and add a comment explaining why the current behavior is correct if it turns out to be right).

@ianprime0509 ianprime0509 added the enhancement New feature or request label Oct 15, 2023
@ianprime0509
Copy link
Owner Author

No longer relevant with #36.

@ianprime0509 ianprime0509 closed this as not planned Won't fix, can't repro, duplicate, stale Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant