-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the migration script to work with new psql db #47
Update the migration script to work with new psql db #47
Conversation
5d9caff
to
2f0d248
Compare
The foreign key constraint is causing some problems with bad data in my local database, I don't think we'll hit the same issues on prod (especially if we're ignoring the old stuff) but I just pulled the latest DB dump to test out tomorrow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a couple suggestions :-)
5945ef2
to
c7d3760
Compare
faca18b
to
05dee12
Compare
47b1d7a
to
8fdc189
Compare
8fdc189
to
40616eb
Compare
OK @rsnyman I think this is finally in the "final" state. I applied a similar logic for the artifact files that is done for the results so that we can avoid any foreign key constraint errors (i.e. getting a list of migrated results and searching for artifacts within that result list). |
Leaving as a draft until we figure out the indexes we need.
Some things I considered:
upload_date
field to the artifact modelI got many of the column indexes, but there are still the JSON indexes to consider.
@rsnyman I'd figure I make this part of ibutsu-server so that we can use the models'
from_dict
method that we have defined in the db models.The pre-commit update is because I hit PyCQA/pycodestyle#373