feat: off dot-notation

Author: fyangstudio

package.json

@@ -20,7 +20,7 @@
   },
   "scripts": {
     "prepare": "husky install",
-    "setup": "lerna bootstrap --no-ci && lerna link",
+    "setup": "rm -rf ./packages/*/node_modules && lerna bootstrap --no-ci && lerna link",
     "lint": "eslint --ext .js,.jsx,.tsx,.ts ./ --resolve-plugins-relative-to ./packages/spec",
     "prettier": "prettier **/* --write",
     "test": "jest && cd packages/spec && npm run test",

packages/eslint-plugin-best-practices/CHANGELOG.md

@@ -1,5 +1,8 @@
 # changelog
 
+## 0.2.10
+- Update stylistic rules `dot-notation` and `@typescript-eslint/dot-notation` from error to off.
+
 ## 0.2.9
 
 - Update stylistic rules `semi` `eol-last` and `quote-props` from error to warn.

packages/eslint-plugin-best-practices/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@iceworks/eslint-plugin-best-practices",
-  "version": "0.2.9",
+  "version": "0.2.10",
   "description": "Iceworks best practices eslint plugin.",
   "files": [
     "docs/",

packages/eslint-plugin-best-practices/src/configs/common.js

@@ -27,14 +27,15 @@ module.exports = {
     },
   ],
   rules: {
+    'dot-notation': 'off',
     'max-len': ['warn', 120, 2, {
       ignoreUrls: true,
       ignoreComments: false,
       ignoreRegExpLiterals: true,
       ignoreStrings: true,
       ignoreTemplateLiterals: true,
     }],
-    semi: 'warn',
+    'semi': 'warn',
     'eol-last': 'warn',
     'quote-props': 'warn',
     '@iceworks/best-practices/no-http-url': 'warn',

packages/eslint-plugin-best-practices/src/configs/rax-ts.js

@@ -6,7 +6,8 @@ module.exports = deepmerge(commonConfig, {
     'max-lines': ['warn', { max: 500 }],
     'no-plusplus': 'off',
     'no-return-await': 'off',
-    semi: 'off',
+    'semi': 'off',
+    '@typescript-eslint/dot-notation': 'off',
     '@typescript-eslint/semi': 'warn',
     '@typescript-eslint/no-unused-vars': 'warn',
   },

packages/eslint-plugin-best-practices/src/configs/react-ts.js

@@ -8,7 +8,8 @@ module.exports = deepmerge(commonConfig, {
     'no-plusplus': 'off',
     'no-return-await': 'off',
     'react/prop-types': 'off',
-    semi: 'off',
+    'semi': 'off',
+    '@typescript-eslint/dot-notation': 'off',
     '@typescript-eslint/semi': 'warn',
     '@typescript-eslint/no-unused-vars': 'warn',
   },

packages/spec/CHANGELOG.md

@@ -2,7 +2,8 @@
 
 ## 1.5.0
 
-- Feat update eslint-config-ali、babel and typescript dependencies to support [email protected]
+- Feat update eslint-config-ali、babel and typescript dependencies to support [email protected].
+- Update stylistic rules `dot-notation` and `@typescript-eslint/dot-notation` from error to off.
 
 ## 1.4.2
 

packages/spec/examples/common-ts/index.ts

@@ -5,3 +5,6 @@ interface AppDeveloper {
 
 const bar = [1, 2];
 const one: AppDeveloper = { name: 'hello', id: 1 };
+
+const t = { s: 1 };
+console.log(t['s']);

packages/spec/examples/common/index.js

@@ -1,2 +1,5 @@
 const foo = [1, 2];
 console.log(foo);
+
+const t = { s: 1 };
+console.log(t['s']);

packages/spec/src/eslint/common-ts.js

@@ -6,10 +6,11 @@ module.exports = {
   ],
   rules: {
     // Change error to warn
-    semi: 'off',
+    'semi': 'off',
     '@typescript-eslint/semi': 'warn',
     'eol-last': 'warn',
     'quote-props': 'warn',
     '@typescript-eslint/no-unused-vars': 'warn',
+    '@typescript-eslint/dot-notation': 'off',
   },
 };

packages/spec/src/eslint/common.js

@@ -6,9 +6,10 @@ module.exports = {
   ],
   rules: {
     // Change error to warn
-    semi: 'warn',
+    'semi': 'warn',
     'eol-last': 'warn',
     'quote-props': 'warn',
     'no-unused-vars': 'warn',
+    'dot-notation': 'off',
   },
 };

packages/spec/src/eslint/vue-ts.js

@@ -6,10 +6,11 @@ module.exports = {
   ],
   rules: {
     // Change error to warn
-    semi: 'off',
+    'semi': 'off',
     '@typescript-eslint/semi': 'warn',
     'eol-last': 'warn',
     'quote-props': 'warn',
     '@typescript-eslint/no-unused-vars': 'warn',
+    '@typescript-eslint/dot-notation': 'off',
   },
 };

packages/spec/src/eslint/vue.js

@@ -6,9 +6,10 @@ module.exports = {
   ],
   rules: {
     // Change error to warn
-    semi: 'warn',
+    'semi': 'warn',
     'eol-last': 'warn',
     'quote-props': 'warn',
     'no-unused-vars': 'warn',
+    'dot-notation': 'off',
   },
 };