Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What is Mapbox Navigation v1.5.1 dependency used for? #66

Open
tsuz opened this issue Nov 18, 2021 · 4 comments
Open

What is Mapbox Navigation v1.5.1 dependency used for? #66

tsuz opened this issue Nov 18, 2021 · 4 comments

Comments

@tsuz
Copy link

tsuz commented Nov 18, 2021

What's the problem?

dev.icerock.moko:maps:0.6.0 has a dependency of com.mapbox.navigation:core:1.5.1 (source via PR) and this means developers that use Mapbox maps will be charged Nav SDK pricing per MAU, even the users are not using any functionality of Mapbox Nav SDK.

Why is this occurring now?

dev.icerock.moko:maps:0.5.2 has a dependency of com.mapbox.mapboxsdk:mapbox-android-navigation:0.42.6 which doesn't charge Mapbox Nav SDK pricing.

What is Mapbox Navigation being used for?

From looking at the code, it doesn't look like we need this library. Can this dependency be removed?

@tsuz tsuz changed the title Remove Mapbox Navigation v1.5.1 dependency What is Mapbox Navigation v1.5.1 dependency used for? Nov 18, 2021
@Alex009
Copy link
Member

Alex009 commented Nov 18, 2021

hi!
as i remember - navigation module needed for build route, here for example - https://github.com/icerockdev/moko-maps/blob/master/maps-mapbox/src/androidMain/kotlin/dev/icerock/moko/maps/mapbox/MapboxController.kt#L274
maybe it's not directly navigation module but some dependency of navigation module...need to check it.
in 0.6.0 we update sdk and old android-navigation module was missed, so we change to navigation core

@tsuz
Copy link
Author

tsuz commented Nov 18, 2021

@Alex009

Thanks for your quick response :)

Using Mapbox Nav SDK V2, the route can also be generated in a similar fashion, while there would be no charge to the end users unless the turn by turn navigation is used.

Is it possible to migrate Mapbox Navigation from v1.5.1 to v2?

@tsuz
Copy link
Author

tsuz commented Dec 22, 2021

@Alex009

Btw, are you open to a PR that updates Mapbox Nav SDK from v1.5.1 to v2? I could give it a try if this is welcome 🙂

@Alex009
Copy link
Member

Alex009 commented Dec 22, 2021

@tsuz yes, try please. any help is beautiful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants