Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Surgery table is not able to be updated #1125

Open
lindaxiang opened this issue Feb 1, 2024 · 5 comments
Open

🐛 Surgery table is not able to be updated #1125

lindaxiang opened this issue Feb 1, 2024 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@lindaxiang
Copy link

Describe the bug

The surgery table is not able to be updated once submitted.

Steps To Reproduce

Steps to reproduce the behaviour:

  1. Go to 'https://platform-ui.argo-qa.cumulus.genomeinformatics.org/'
  2. Click on project 'PACA-CA' or other projects
  3. If you already have surgery records submitted
  4. Re-submit the surgery table with or without changes
  5. Click the Validate submission button
  6. it will give the error message:
    The submitter_specimen_id '*****' has already been associated with a surgery in the current or previous submission. Specimen can only be submitted once for a single surgery.

Expected behaviour

The surgery table should be updated accordingly without errors.

@lindaxiang lindaxiang added the bug Something isn't working label Feb 1, 2024
@demariadaniel demariadaniel self-assigned this Feb 5, 2024
@demariadaniel
Copy link
Contributor

Bug is actually the result of existing validation created in:
https://app.zenhub.com/workspaces/icgc-argo-platform-dk-production-board-5e542d38415f5034e9fed89d/issues/gh/icgc-argo/argo-clinical/773

&

#738

Will need to discuss solution that allows updating existing records, without creating duplicates
Any current issues with existing records can be resolved by deleting records & resubmitting

@demariadaniel
Copy link
Contributor

Tested successful update scenario:

Screenshot 2024-03-11 at 5.03.04 PM.png

@demariadaniel
Copy link
Contributor

Update success case TSV file:
surgery_resubmit_test1_update.txt

(tsv is not supported by zenhub, converted to txt)

@demariadaniel
Copy link
Contributor

Validation successfully shows error for duplicate record:

Screenshot 2024-03-11 at 5.00.37 PM.png

@demariadaniel
Copy link
Contributor

Error case record:

surgery_resubmit_test2_duplicate.txt

@bhavikbhagat93 bhavikbhagat93 removed their assignment May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants