Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change validation logic for fields: “drug_name” and “drug_rxnormcui” #1194

Open
3 tasks
lindaxiang opened this issue Sep 6, 2024 · 3 comments
Open
3 tasks
Assignees

Comments

@lindaxiang
Copy link

lindaxiang commented Sep 6, 2024

Context

  1. Current data model only accept and validate the “drug_name” and “drug_id” using RxNorm database
  2. RxNorm only includes drugs that are approved in the USA.
  3. Drugs for clinical trials normally do not have RxNorm ID.
  4. International programs could use a different drug database other than RxNorm.

Use cases

  • POG-CA has 65 Drugs without RxNormIDs, which will affect about 50 records among ~3500 treatment records.
  • MONSTAR-JP has 30% donors (~600 donors) who were treated with drugs (12 different drugs) which do not have RxNormID. Instead they have KEGG Ids.

Proposal

  1. Data model changes: ticket
  2. Clinical validation changes: change the current validation logic to either validate the “drug_name” and “drug_rxnormcui” against the RxNorm database, or check if the new conditional fields “drug_database”, “drug_id” and “drug_term” are populated.
  • If both drug_rxnormid & drug_name are submitted, then check that they are a valid id/name pair in the RxNorm Data Source
  • If drug_rxnormid & drug_name are not submitted, then check if fields drug_database, drug_id and drug_term are submitted. No validations are needed for these 3 fields atm.
  • If both sets of data fields are not submitted, a validation error will appear like this:
    Please provide the missing drug information.
  1. Three tables are affected: chemotherapy, hormone_therapy and immunotherapy
@demariadaniel
Copy link
Contributor

PR currently adds an error for every field that is missing. This can be changed to only add error if all 3 are missing.

@lindaxiang
Copy link
Author

  1. Test the above files in QA for program DATA-CA
Screenshot 2024-09-29 at 7 42 49 PM
  1. Test the following clinical files in QA for program MONSTAR-JP
Screenshot 2024-09-29 at 7 54 50 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants