Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can submit an application that is missing a signed app document #280

Open
anncatton opened this issue Dec 23, 2021 · 1 comment
Open

Can submit an application that is missing a signed app document #280

anncatton opened this issue Dec 23, 2021 · 1 comment
Assignees
Labels
bug Something isn't working low

Comments

@anncatton
Copy link
Contributor

anncatton commented Dec 23, 2021

Steps to reproduce:

  • create a new app and complete all the sections including adding 1 collaborator, until you are in SIGN AND SUBMIT state
  • upload a signed application
  • delete the collaborator
    The signed application is deleted from the signature section, but the status is still marked as COMPLETE, and you can submit the application for REVIEW from the api. (The submit button is disabled on the ui.)

The application should not be able to transition to REVIEW state without an uploaded signed app document.

Note: Possibly related to using resetSignedDocument() somewhere in this flow instead of transitionToSignAndSubmitOrRollBack()

@anncatton anncatton self-assigned this Dec 23, 2021
@kcullion kcullion added this to the DACO Application - Kannbanne milestone Feb 22, 2022
@b-f-chan b-f-chan added bug Something isn't working low labels Apr 3, 2023
@b-f-chan
Copy link

b-f-chan commented Apr 4, 2023

Difficult to reproduce, icebox for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working low
Projects
None yet
Development

No branches or pull requests

3 participants