Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove GRPC Clients and Configs #689

Open
4 tasks
joneubank opened this issue Oct 19, 2023 · 1 comment
Open
4 tasks

Remove GRPC Clients and Configs #689

joneubank opened this issue Oct 19, 2023 · 1 comment
Assignees
@demariadaniel @daniel-cy-lu
Labels
new-feature Request is a new feature

Comments

@joneubank
Copy link
Member

We have removed all GRPC dependencies from the program service and from Ego, so now we want to remove those from the platform API. In particular the code that established the GRPC connection needs to be removed.

There is GRPC code written for Ego and for Program Service - all of it should be removed.

Detailed Description

  • Remove Program Service GRPC client
  • Remove any code creating GRPC connection to Program Service
  • Remove config variables related to GRPC
  • Remove Ego GRPC client code
@joneubank joneubank added the new-feature Request is a new feature label Oct 19, 2023
@demariadaniel demariadaniel self-assigned this Jan 31, 2024
@demariadaniel
Copy link
Contributor

#714

demariadaniel added a commit that referenced this issue Feb 7, 2024
@demariadaniel @daniel-cy-lu
✂️ #689 Remove GRPC Client and Config (#714)
80d3a1f 
* commit before branch change

* replacing GRPC to HTTP method for public single program, private single program and private program list endpoints

* remove comments

* add joinProgramInvite http fetch and update resolver. some resolved error remain. git commit before switching branch

* fix error from date values and waiting program service to fix first and last name

* remove unused key value pairs in joinProgramInvite response

* updated name

* edit http fetch to match new Program Service api data format

* remove testing console.log

* add userList resolver and http fetch

* create program endpoint

* createProgram client is completed

* update inviteUser to use HTTP

* commit before branch switch

* commit before chaning branch

* joinProgram, updateUser fetch and resolver working, updateProgram waiting for testing

* Add Copyright

* Fix Empty Field Errors

* Edit

* Working Regions

* Remove Whitespace

* Fix Name Values

* Make required User fields non-nullable

* Remove References to GRPC

* Consolidate programService index file

* Remove old GRPC Comments

* Data Centers / Update Program Syntax improvement

* Fix Copyright Date

---------

Co-authored-by: Daniel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@demariadaniel demariadaniel

@daniel-cy-lu daniel-cy-lu

Labels
new-feature Request is a new feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@joneubank @demariadaniel @daniel-cy-lu