Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gulp tasks do not declare completion #593

Open
bignose-debian opened this issue Feb 22, 2022 · 2 comments
Open

Gulp tasks do not declare completion #593

bignose-debian opened this issue Feb 22, 2022 · 2 comments

Comments

@bignose-debian
Copy link

Gulp as of version 4 runs all tasks asynchronously. It passes to each task a callback function; if that function is not called, the task is assumed to fail.

The current gulpfile.js defines tasks that will fail in current versions of Gulp:

[22:17:41] The following tasks did not complete: coffee
[22:17:41] Did you forget to signal async completion?
@bignose-debian
Copy link
Author

The Gulp documentation for asynchronous task completion specifies that synchronous task functions are no longer supported:

Synchronous tasks are no longer supported. They often led to subtle mistakes that were hard to debug, like forgetting to return your streams from a task.

When you see the "Did you forget to signal async completion?" warning, none of the techniques mentioned above were used. You'll need to use the error-first callback or return a stream, promise, event emitter, child process, or observable to resolve the issue.

@bignose-debian
Copy link
Author

This is addressed in the branch ‘wip/issue/593/gulp-async-task-signal-completion’ in my personal fork repository. The branch merges cleanly to current ‘master’ branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant