fixed bug where h5py downloads incompatible version of cython #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
h5py needs cython to compile. When cython is not installed on the machine it will automatically download cython to compile itself. Currently, the version of cython that it downloads is 3.0a1, which is unable to compile h5py. This bug is with h5py/cython and not directly stemming from image-super-resolution, but it is causing bugs downstream in this project. To fix this issue you just need to make sure that cython is installed on the machine first (with a compatible version). It would be good practice to include a specific version range in setup.py, but for now this works.
guy on h5py repo issues section discussing this solution