The Hero info button in level up dialog has black background

[zenseii]

Preliminary checks

• I've checked that there aren't other open issues on the same topic.
• I've checked that this issue is reproducible on the latest snapshot build.

Platform

Windows

Describe the bug

Seen here:

It is the same background as it has in the adventure map buttons

Save file

No need.

Additional info

No response

[zenseii]

I believe this is a regression from this PR:
#7449

[LeHerosInconnu]

I confirm this in my current game with version 1.0.6 7494.

In fheroes2:

Here is the save file:
Hero button 01.zip

[zenseii]

The problem here is that the function calls AddTransparency(), but after the PR mentioned above these images do not have a transformation layer, rightly so since they don't need them where they are supposed to be used on the right side column of the adventure map, and you can't add transparency to a single-layered image if I've understood things correctly.

fheroes2/src/fheroes2/agg/agg_image.cpp

Lines 3147 to 3162 in d7ee114

	case ICN::GOOD_ARMY_BUTTON:
	case ICN::GOOD_MARKET_BUTTON: {
	_icnVsSprite[id].resize( 2 );
	LoadOriginalICN( ICN::ADVBTNS );
	const int releasedIndex = ( id == ICN::GOOD_ARMY_BUTTON ) ? 0 : 4;
	_icnVsSprite[id][0] = GetICN( ICN::ADVBTNS, releasedIndex );
	_icnVsSprite[id][1] = GetICN( ICN::ADVBTNS, releasedIndex + 1 );
	// Make all black pixels transparent.
	AddTransparency( _icnVsSprite[id][0], 36 );
	AddTransparency( _icnVsSprite[id][1], 36 );
	AddTransparency( _icnVsSprite[id][1], 61 ); // remove the extra brown border
	return true;
	}

I'm not entirely sure if I should figure out how to add transparency back to this button and create a new modified ICN, or if I should just add a fixed uniform button background to it and make a new ICN. Most likely the second option is the way to go.

Any advice would be appreciated, @ihhub and @Districh-ru.