Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MultiScatter/Scatter: refactor logic for providing fill to <Symbol /> #93

Open
GabeMedrash opened this issue Feb 3, 2017 · 1 comment
Open

MultiScatter/Scatter: refactor logic for providing fill to <Symbol /> #93

GabeMedrash opened this issue Feb 3, 2017 · 1 comment
Labels
bug

Comments

@GabeMedrash
Copy link
Contributor

Currently, the only way to reliably provide the same fill to an entire <Scatter /> is to provide a dataAccessor.fill. While <MultiScatter /> exposes fieldAccessors.color, relying on it depends on const fillValue = propResolver(datum, dataAccessors.fill || dataAccessors.x); resolving to a non-finite value. That's wonky!

Providing fieldAccessor.color should reliably determine fill for an entire <Scatter />.
@GabeMedrash GabeMedrash added the bug label Feb 3, 2017
@GabeMedrash
Copy link
Contributor Author

Notes:

  • default MultiScatter.defaultProps.colorScale to _.identity
  • use case of inconsistently applying color scale
  • whether or not Scatter.props.fill takes precedence in Scatter::render

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@GabeMedrash