Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear weeds #65

Open
igrep opened this issue Nov 27, 2018 · 1 comment
Open

Clear weeds #65

igrep opened this issue Nov 27, 2018 · 1 comment

Comments

@igrep
Copy link
Contributor

igrep commented Nov 27, 2018

There're many excessive exports and unnecessary dependencies, detected by weeder.
Let's delete really unnecessary ones.

@igrep
Copy link
Contributor Author

igrep commented Nov 27, 2018

Ref: The output of weeder at 35c9554:

> weeder .
= Package direct-hs-examples =

== Section exe:login exe:nippo exe:observe-pretty exe:ping ==
Module reused between components
* Common
Weeds exported
* Common
  - exitError

== Section exe:observe-pretty ==
Excessive other-modules entry
* Common

= Package network-messagepack-rpc =
No warnings

= Package network-messagepack-rpc-websocket =

== Section test:spec ==
Module not compiled
* Network.MessagePack.RPC.Client.WebSocketSpec
* Spec.hs
Redundant build-depends entry
* QuickCheck
* async
* bytestring
* data-msgpack
* envy
* hspec
* network-messagepack-rpc
* network-messagepack-rpc-websocket
* skews
* text
* wss-client

= Package direct-hs =

== Section library ==
Redundant build-depends entry
* unordered-containers
Weeds exported
* Web.Direct.Client
  - getCurrentDomain
  - setCurrentDomain
* Web.Direct.Client.Channel.Types
  - channelTalkId
* Web.Direct.Client.Status
  - Inactive
* Web.Direct.DirectRPC
  - apiVersion
* Web.Direct.DirectRPC.Map
  - decodeDomain
  - decodeUser
* Web.Direct.Message
  - encodeFile

= Package wss-client =

== Section exe:wss-client-sample ==
Module not compiled
* sample.hs
Redundant build-depends entry
* bytestring
* wss-client

== Section test:wss-client-test ==
Module not compiled
* Network.WebSockets.ClientSpec
* Spec.hs
Redundant build-depends entry
* bytestring
* envy
* hspec
* skews
* text
* wss-client

= Package skews =

== Section test:mock-ws-server-test ==
Module not compiled
* Network.WebSockets.SkewsSpec
* Spec.hs
Redundant build-depends entry
* async
* bytestring
* deque
* envy
* hspec
* network
* skews
* websockets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant