Hold JNIEnv pointer using SafeHandle.

Call through to V methods, just to check that we can. We can. Add verbosity and diag back.
ikvmnet · Sep 15, 2023 · 2d053c4 · 2d053c4
1 parent 299e59b
commit 2d053c4
Show file tree

Hide file tree

Showing 6 changed files with 332 additions and 309 deletions.
diff --git a/.github/workflows/IKVM.yml b/.github/workflows/IKVM.yml
@@ -604,9 +604,9 @@ jobs:
                 "--blame-crash",
                 "--blame-hang",
                 "--blame-hang-timeout", "30m",
-                "-v", "2",
+                "-v:diag",
                 "--results-directory", "TestResults",
-                "--logger:console;verbosity=detailed",
+                "--logger:console;verbosity=diag",
                 "--logger:trx",
                 "--collect", "'Code Coverage'"
             )

diff --git a/src/IKVM.Runtime/JNI/JNIEnv.cs b/src/IKVM.Runtime/JNI/JNIEnv.cs
@@ -25,7 +25,6 @@ Jeroen Frijters
 using System.Collections.Generic;
 using System.Diagnostics;
 using System.Reflection;
-using System.Runtime.CompilerServices;
 using System.Runtime.InteropServices;
 
 using IKVM.ByteCode.Text;
@@ -424,7 +423,7 @@ internal static string DecodeMUTF8(byte* psz)
         /// <param name="method"></param>
         /// <param name="sig"></param>
         /// <returns></returns>
-        internal static int GetMethodArgs(JNIEnv* pEnv, nint method, byte* sig)
+        internal static int GetMethodArgs(JNIEnv* pEnv, jmethodID method, byte* sig)
         {
             var args = RuntimeJavaMethod.FromCookie(method).GetParameters();
             for (var i = 0; i < args.Length; i++)